fix: group contiguous note edits into a single undo step by patbyte · Pull Request #4524 · cybersemics/em

patbyte · 2026-07-06T06:18:44Z

Route note edits through editThought instead of setDescendant so consecutive note changes merge in the undo stack, and mark toggleNote as non-undoable.

This PR fixes #4479.

Changes:

Note edits now dispatch editThought when the note value thought already exists, so they use the existing directional undo chunking logic
Empty note creation is no longer undoable
Added undo/redo coverage for note additions, deletes, replacements, and empty-note creation

Route note edits through editThought instead of setDescendant so consecutive note changes merge in the undo stack, and mark toggleNote as non-undoable.

github-actions · 2026-07-06T06:20:54Z

Vercel preview: https://em-h6mey5gwb-cybersemics.vercel.app

BayuAri · 2026-07-07T02:11:52Z

Issue A: Undo is splitted into 2 stacks for replacing a word on Notes

- One
- Two

Step to Reproduce

Create a new Note under One
Type The world of beautiful birds
Change the birds word into people
Click Undo

Current behavior

The first Undo the replaced word becomes p
The second Undo the word is reverted to birds

Fast.type.mov

Slow.Type.mov

Expected behavior

The first Undo should revert to the original birds

BayuAri · 2026-07-07T02:40:23Z

Issue B: Backspace / Delete is not working and caret is moved to the end of the thought text after Undo on the first thought

Step to Reproduce

Create a new Note under One
Type The world of birds
Select the word world
Change the word into cage
Click Undo to revert back to world
Hit Delete button on the keyboard several time

Current behavior

Nothing happens.
The caret is moved to the end of the thought text.
Workaround: move the caret next to the desired word to make it works again to delete/backspace.

Issue.B.Backspace.Delete.is.not.working.after.Undo.MP4

Expected behavior

Backspace/delete should work after Undo action.
The caret should be placed where it left off

BayuAri · 2026-07-07T02:53:43Z

Issue C: Undo a new Notes creation is Undoing the last action prior the creating the new Notes but leaving the empty Notes

Step to Reproduce

Create a new thought
Add a text One
Click Add Notes button
Click Undo

Current behavior

One text is undone.
Newly created empty Note remains.
Undo again deletes the thought.

Issue.C.Undo.a.new.Notes.creation.is.Undoing.the.last.action.prior.the.creating.the.new.Notes.but.leaving.the.empty.Notes.MP4

Expected behavior

Newly created empty note should be deleted

BayuAri · 2026-07-07T03:09:18Z

Issue D: Backspace/Delete button on the keyboard deletes the thought space.

- One
- Two

Step to Reproduce

Create a new Notes on Thought Two
Type Hello World
Change Hello to Great
Tap Undo
Tap Backspace/Delete button on the keyboard

Current behavior

Thought space is deleted.
Two text is merged onto the above One along with the Notes
This is related to Issue B

Issue.D.Backspace.Delete.button.on.the.keyboard.deletes.the.thought.space.MP4

Expected behavior

Backspace/Delete button on the keyboard should serve to delete the character before the caret.

BayuAri

List of issues:

Issue A: Undo is split into 2 stacks for replacing a word on Notes
Issue B: Backspace / Delete is not working and caret is moved to the end of the thought text after Undo on the first thought
Issue C: Undo a new Notes creation is Undoing the last action prior the creating the new Notes but leaving the empty Notes
Issue D: Backspace/Delete button on the keyboard deletes the thought space.

@raineorshine
Question about Issue A, is this intended as the implementation of Replacements → separate undo steps

Refer to

Replacements → separate undo steps
#4479 (comment)

raineorshine · 2026-07-07T21:50:37Z

@raineorshine
Question about Issue A, is this intended as the implementation of Replacements → separate undo steps

This raises a good question, though for the purpose of this issue we are just aiming to reproduce the undo/redo behavior that currently exists for normal thoughts. So for any edit to a note, check how many undo/redo steps are created if the same edit is applied to a normal thought.

That should be enough to figure out the intended functionality, but to answer your specific question about Issue A, you have come up with a case that I don't think I had considered yet, and I'm not sure how this is handled in the code currently. I think the code currently categorizes edits based on the string length delta:

ADD: a (1) → ab (2)
DELETE: ab (2) → a (1)
REPLACE: a (1) → b (1)

Issue A is unique in that it is a replacement, but the number of characters are not the same. I think birds (5) → people (6) would currently be categorized by an addition, which is probably wrong (i.e. a bug in normal thought undo/redo). Categorizing it as a replacement so that it gets its own undo step and is not merged with other contiguous additions makes more sense.

However, that's all out of scope for this issue, whose main purpose is to implement baseline undo/redo chunking to notes. This was understandably not so clear from my hasty bug report.

raineorshine · 2026-07-09T18:15:32Z

@patbyte Is this ready for review or are you still working on it? Once ready, please use the GitHub "Request Review" feature to request a behavioral review from Bayu. Then I will review once behavior is confirmed.

Thanks!

BayuAri · 2026-07-10T15:10:10Z

Issue E: Unable to partial select on the note text

Step to Reproduce

Create a new thought with text
Add a note with text
Place the caret on the note
Double click on any word on the note or click and drag to select

Current behavior

Selection highlight is flashing and it is not selecting the text

Issue.E.Unable.to.partial.select.on.the.note.text.mov

Expected behavior

User should be able to select text with double click or click and drag

patbyte · 2026-07-10T15:12:33Z

Hi @BayuAri , What about the issues from A to D?
All working well?

BayuAri · 2026-07-10T15:14:56Z

Hi @BayuAri , What about the issues from A to D? All working well?

I'll report that on my Review comment at the end of the testing.
Will get there.

I log the issue per comment so we can reference this easily on the Review comment linking.

BayuAri

@patbyte
Test result
List of issues:

Issue A: Undo is split into 2 stacks for replacing a word on Notes

Testing is blocked by Issue E

Issue B: Backspace / Delete is not working and caret is moved to the end of the thought text after Undo on the first thought

Fixed

Issue C: Undo a new Notes creation is Undoing the last action prior the creating the new Notes but leaving the empty Notes

Fixed

Issue D: Backspace/Delete button on the keyboard deletes the thought space.

Partially fixed

This is considered as fixed because the caret is placed at the beginning of the notes, however, hitting Backspace when the caret is at the beginning of the Notes will delete the note and merge the notes text into thought text.

Step to Reproduce

- One 
- Two

Create a note under Thought Two

Add a text onto the Notes

Place the caret at the beginning of the Notes text

Hit Backspace on the keyboard

Current behavior

Notes text merges with the Thought Text.

Expected behavior

@raineorshine
Please help with the expected result.
This refers to the behavior of Thought but it is kind of weird when on Notes.
I think nothing should happen here.
This is not a regression issue but behavioral question because this exist on main

New regression issue:

Issue E: Unable to partial select on the note text

patbyte · 2026-07-10T16:28:51Z

@BayuAri , Thanks for your testing.
Let me fix all of them and will let you know.

fix: group contiguous note edits into a single undo step

992f87e

Route note edits through editThought instead of setDescendant so consecutive note changes merge in the undo stack, and mark toggleNote as non-undoable.

raineorshine requested a review from BayuAri July 6, 2026 15:24

raineorshine approved these changes Jul 6, 2026

View reviewed changes

BayuAri reviewed Jul 7, 2026

View reviewed changes

BayuAri requested changes Jul 7, 2026

View reviewed changes

fix: handle note undo review regressions

5567ec9

patbyte requested a review from BayuAri July 10, 2026 06:23

BayuAri reviewed Jul 10, 2026

View reviewed changes

Fix note selection and backspace handling

c16bfe6

patbyte requested a review from BayuAri July 10, 2026 18:54

Uh oh!

Conversation

patbyte commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BayuAri commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue A: Undo is splitted into 2 stacks for replacing a word on Notes

Step to Reproduce

Current behavior

Expected behavior

Uh oh!

BayuAri commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue B: Backspace / Delete is not working and caret is moved to the end of the thought text after Undo on the first thought

Step to Reproduce

Current behavior

Expected behavior

Uh oh!

BayuAri commented Jul 7, 2026

Issue C: Undo a new Notes creation is Undoing the last action prior the creating the new Notes but leaving the empty Notes

Step to Reproduce

Current behavior

Expected behavior

Uh oh!

BayuAri commented Jul 7, 2026

Issue D: Backspace/Delete button on the keyboard deletes the thought space.

Step to Reproduce

Current behavior

Expected behavior

Uh oh!

BayuAri left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raineorshine commented Jul 7, 2026

Uh oh!

raineorshine commented Jul 9, 2026

Uh oh!

BayuAri commented Jul 10, 2026

Issue E: Unable to partial select on the note text

Step to Reproduce

Current behavior

Expected behavior

Uh oh!

patbyte commented Jul 10, 2026

Uh oh!

BayuAri commented Jul 10, 2026

Uh oh!

BayuAri left a comment

Choose a reason for hiding this comment

Step to Reproduce

Current behavior

Expected behavior

Uh oh!

patbyte commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 6, 2026 •

edited

Loading

BayuAri commented Jul 7, 2026 •

edited

Loading

BayuAri commented Jul 7, 2026 •

edited

Loading

BayuAri left a comment •

edited

Loading